linux-kernel - Re: [PATCH] net/can: rename peak_usb dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5044721B.8030507@pengutronix.de>
Date:	Mon, 03 Sep 2012 11:02:19 +0200
From:	Marc Kleine-Budde <mkl@...gutronix.de>
To:	Randy Dunlap <rdunlap@...otime.net>
CC:	netdev@...r.kernel.org, Geert Uytterhoeven <geert@...ux-m68k.org>,
	linux-kernel@...r.kernel.org, David Miller <davem@...emloft.net>,
	Stephane Grosjean <s.grosjean@...k-system.com>,
	Wolfgang Grandegger <wg@...ndegger.com>,
	linux-can@...r.kernel.org
Subject: Re: [PATCH] net/can:  rename peak_usb dump_mem function

On 09/02/2012 07:13 PM, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@...otime.net>
> 
> Rename generic-sounding function dump_mem() to pcan_dump_mem()
> so that it does not conflict with the dump_mem() function in
> arch/sh/include/asm/kdebug.h.
> 
> drivers/net/can/usb/peak_usb/pcan_usb_core.c: error: conflicting types for 'dump_mem':  => 56:6
> drivers/net/can/usb/peak_usb/pcan_usb_core.h: error: conflicting types for 'dump_mem':  => 134:6
> 
> Not tested.

:) I've converted the users of peak's dump_mem() function, too. Now it
compiles. Should this go into v3.6, or is v3.7 early enough?

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


Download attachment "signature.asc" of type "application/pgp-signature" (260 bytes)