linux-kernel - Re: [PATCH] builddeb: remove unneeded explicit Architecture

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120906162143.GN18204@xorcom.com>
Date:	Thu, 6 Sep 2012 19:21:43 +0300
From:	Tzafrir Cohen <tzafrir.cohen@...com.com>
To:	maximilian attems <max@...o.at>
Cc:	Michal Marek <mmarek@...e.cz>,
	Linux Kbuild <linux-kbuild@...r.kernel.org>,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] builddeb: remove unneeded explicit Architecture

On Thu, Sep 06, 2012 at 02:04:16PM +0000, maximilian attems wrote:
> On Thu, Sep 06, 2012 at 02:00:04PM +0000, maximilian attems wrote:
> > On Wed, Sep 05, 2012 at 08:26:05PM +0000, maximilian attems wrote:
> > > On Wed, Sep 05, 2012 at 07:40:09PM +0300, Tzafrir Cohen wrote:
> > > > 
> > > > $ grep CROSS_COMPILE .config
> > > > CONFIG_CROSS_COMPILE="arm-linux-gnueabihf-"
> > > > 
> > > > Command:
> > > > 
> > > >   KBUILD_DEBARCH=armhf make ARCH=arm KBUILD_IMAGE=uImage deb-pkg
> > > > 
> > > > Error I get:
> > > > 
> > > >   dpkg-gencontrol: error: current host architecture 'armhf' does not
> > > >   appear in package's architecture list (amd64)
> > > > 
> > > > It seems I have to use KBUILD_DEBARCH, as the kernel build system can't
> > > > really tell if I want armel or armhf (If I built the same kernel for a
> > > > Squeeze system I would have been forced to use armel).
> > > 
> > > well, obviously the dpkg call in
> > >  -arch=$(dpkg --print-architecture)
> > > is wrong please fix that.
> > > 
> > 
> > care to test belows:
> > 
> 
> without a useless snippet about the lost forcearch v2:
> 
> >From f78afbe0b7fa7c49656f4ed1cf404e915f3c325b Mon Sep 17 00:00:00 2001
> From: maximilian attems <max@...o.at>
> Date: Thu, 6 Sep 2012 15:22:02 +0200
> Subject: [PATCH v2] deb-pkg: Simplify architecture matching for cross building
> 
> No point in invoking dpkg to get the archticture of the host
> we build on. Instead directly use the logic implemented
> in create_package(). No need anymore to override arch.

Works for the case I presented. I still have one bad case:

Now I remove the explicit setting of KBUILD_DEBRCH:

  $ rm -rf debian
  $ make ARCH=arm KBUILD_IMAGE=uImage deb-pkg

  ...

  dpkg-gencontrol: error: current host architecture 'armhf' does not
  appear in package's architecture list (armel)

My host architecture is amd64. This is actually the build architecture.
dpkg-gencontrol uses Dpkg::Arch::get_host_arch().

  $ perl -MDpkg::Arch -e 'print Dpkg::Arch::get_host_arch()."\n"'
  amd64

  $ CC=/usr/bin/arm-linux-gnueabi-gcc  perl -MDpkg::Arch -e 'print Dpkg::Arch::get_host_arch()."\n"'
  armel
  
  $ CC=/usr/bin/arm-linux-gnueabihf-gcc  perl -MDpkg::Arch -e 'print Dpkg::Arch::get_host_arch()."\n"'
  armhf

  $ DEB_HOST_ARCH=whatever perl -MDpkg::Arch -e 'print Dpkg::Arch::get_host_arch()."\n"'
  whatever

Is it OK to use that perl one-liner as the default instead of the
architecture guessing case?

-- 
               Tzafrir Cohen
icq#16849755              jabber:tzafrir.cohen@...com.com
+972-50-7952406           mailto:tzafrir.cohen@...com.com
http://www.xorcom.com  iax:guest@...al.xorcom.com/tzafrir
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/