linux-kernel - Re: [PATCH] builddeb: remove unneeded explicit Architecture

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120907000209.GA5993@stro.at>
Date:	Fri, 7 Sep 2012 02:02:09 +0200
From:	maximilian attems <max@...o.at>
To:	Tzafrir Cohen <tzafrir.cohen@...com.com>
Cc:	Michal Marek <mmarek@...e.cz>,
	Linux Kbuild <linux-kbuild@...r.kernel.org>,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] builddeb: remove unneeded explicit Architecture

On Thu, 06 Sep 2012, Tzafrir Cohen wrote:
>
> Works for the case I presented.

Michal please care to queue previous v2 patch with
Tested-by: Tzafrir Cohen <tzafrir.cohen@...com.com>
to kope with that cross building regression since
the linux headers got added to deb-pkg target.

> Now I remove the explicit setting of KBUILD_DEBRCH:

and here lies the error.
 
>   $ rm -rf debian
>   $ make ARCH=arm KBUILD_IMAGE=uImage deb-pkg
> 
>   ...
> 
>   dpkg-gencontrol: error: current host architecture 'armhf' does not
>   appear in package's architecture list (armel)
> 
> My host architecture is amd64. This is actually the build architecture.
> dpkg-gencontrol uses Dpkg::Arch::get_host_arch().
> 
>   $ perl -MDpkg::Arch -e 'print Dpkg::Arch::get_host_arch()."\n"'
>   amd64
> 
>   $ CC=/usr/bin/arm-linux-gnueabi-gcc  perl -MDpkg::Arch -e 'print Dpkg::Arch::get_host_arch()."\n"'
>   armel
>   
>   $ CC=/usr/bin/arm-linux-gnueabihf-gcc  perl -MDpkg::Arch -e 'print Dpkg::Arch::get_host_arch()."\n"'
>   armhf
> 
>   $ DEB_HOST_ARCH=whatever perl -MDpkg::Arch -e 'print Dpkg::Arch::get_host_arch()."\n"'
>   whatever
> 
> Is it OK to use that perl one-liner as the default instead of the
> architecture guessing case?

In any case that would be a follow up, but I'm not fond of that perl/dpkg
magic plus supporting DEB_ variables. I think for linux it is preferable
to have it based on UTS_MACHINE. Thus I think your testcases aren't valid,
and also you neglected the following one:
make KBUILD_DEBARCH=i386 deb-pkg # i386 userland with amd64 linux

Best.

-- 
maks
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/