linux-kernel - Re: [PATCH] builddeb: remove unneeded explicit Architecture

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 9 Sep 2012 14:54:44 +0300
From:	Tzafrir Cohen <tzafrir.cohen@...com.com>
To:	maximilian attems <max@...o.at>
Cc:	Michal Marek <mmarek@...e.cz>,
	Linux Kbuild <linux-kbuild@...r.kernel.org>,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] builddeb: remove unneeded explicit Architecture

On Fri, Sep 07, 2012 at 02:02:09AM +0200, maximilian attems wrote:
> On Thu, 06 Sep 2012, Tzafrir Cohen wrote:
> >
> > Works for the case I presented.
> 
> Michal please care to queue previous v2 patch with
> Tested-by: Tzafrir Cohen <tzafrir.cohen@...com.com>
> to kope with that cross building regression since
> the linux headers got added to deb-pkg target.
> 
> > Now I remove the explicit setting of KBUILD_DEBRCH:
> 
> and here lies the error.
>  
> >   $ rm -rf debian
> >   $ make ARCH=arm KBUILD_IMAGE=uImage deb-pkg
> > 
> >   ...
> > 
> >   dpkg-gencontrol: error: current host architecture 'armhf' does not
> >   appear in package's architecture list (armel)
> > 
> > My host architecture is amd64. This is actually the build architecture.
> > dpkg-gencontrol uses Dpkg::Arch::get_host_arch().
> > 
> >   $ perl -MDpkg::Arch -e 'print Dpkg::Arch::get_host_arch()."\n"'
> >   amd64
> > 
> >   $ CC=/usr/bi/narm-linux-gnueabi-gcc  perl -MDpkg::Arch -e 'print Dpkg::Arch::get_host_arch()."\n"'
> >   armel
> >   
> >   $ CC=/usr/bin/arm-linux-gnueabihf-gcc  perl -MDpkg::Arch -e 'print Dpkg::Arch::get_host_arch()."\n"'
> >   armhf
> > 
> >   $ DEB_HOST_ARCH=whatever perl -MDpkg::Arch -e 'print Dpkg::Arch::get_host_arch()."\n"'
> >   whatever
> > 
> > Is it OK to use that perl one-liner as the default instead of the
> > architecture guessing case?
> 
> In any case that would be a follow up, but I'm not fond of that perl/dpkg
> magic plus supporting DEB_ variables. 

This magic is lifted from current dpkg-gencontrol. Is there any better
way to get it?

> I think for linux it is preferable
> to have it based on UTS_MACHINE. Thus I think your testcases aren't valid,

Well, my current build script is:

  #!/bin/sh
  # YOu need to have one of the following unremmed to avoid a
  # dpkg-gencontrol error:
  export KBUILD_DEBARCH=armhf # Unrem this for armhf
  #export DEB_HOST_ARCH=armel # Or this for armel
  exec make ARCH=arm KBUILD_IMAGE=uImage deb-pkg "$@"

Clearly on my build toolchain I must set DEB_HOST_ARCH in some cases. So
DEB_ variables are already in there. Without it it will give me an error
for trying to build 

> and also you neglected the following one:
> make KBUILD_DEBARCH=i386 deb-pkg # i386 userland with amd64 linux

I'm not sure I follow. If the packagees are to be installed on a i386
system, they are all to be considered i386, right? The linux-image
package as well. The same as
http://packages.debian.org/sid/linux-image-amd64 (the i386 variant).

Setting KBUILD_DEBARCH does not change the building of the files in any
way. It only changes the package's metadata.

Maybe set DEB_HOST_ARCH from KBUILD_DEBARCH if the latter was set?

-- 
               Tzafrir Cohen
icq#16849755              jabber:tzafrir.cohen@...com.com
+972-50-7952406           mailto:tzafrir.cohen@...com.com
http://www.xorcom.com  iax:guest@...al.xorcom.com/tzafrir
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/