linux-kernel - Re: [PATCH v2] watchdog: omap_wdt: convert to new watchdog core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <504F0B99.5090500@ti.com>
Date:	Tue, 11 Sep 2012 15:29:53 +0530
From:	Shubhrajyoti <shubhrajyoti@...com>
To:	Aaro Koskinen <aaro.koskinen@....fi>
CC:	linux-watchdog@...r.kernel.org, linux-omap@...r.kernel.org,
	linux-kernel@...r.kernel.org, jarkko.nikula@...mer.com
Subject: Re: [PATCH v2] watchdog: omap_wdt: convert to new watchdog core

On Saturday 08 September 2012 11:34 PM, Aaro Koskinen wrote:
> -static struct platform_device *omap_wdt_dev;
> -
>  static unsigned timer_margin;
>  module_param(timer_margin, uint, 0);
>  MODULE_PARM_DESC(timer_margin, "initial watchdog timeout (in seconds)");
>  
> -static unsigned int wdt_trgr_pattern = 0x1234;
> -static DEFINE_SPINLOCK(wdt_lock);
> -
you may want to describe this more.
>  struct omap_wdt_dev {
>  	void __iomem    *base;          /* physical */
>  	struct device   *dev;
> -	int             omap_wdt_users;
> +	bool		omap_wdt_users;
>  	struct resource *mem;
> -	struct miscdevice omap_wdt_miscdev;
> +	int		wdt_trgr_pattern;
> +	struct mutex	lock;		/* to avoid races with PM */
>  };
>  

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/