[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87ehm1s28q.fsf@rustcorp.com.au>
Date: Mon, 17 Sep 2012 13:57:17 +0930
From: Rusty Russell <rusty@...tcorp.com.au>
To: "Michael S. Tsirkin" <mst@...hat.com>
Cc: Sjur Brændeland <sjurbren@...il.com>,
Amit Shah <amit.shah@...hat.com>, linux-kernel@...r.kernel.org,
Ohad Ben-Cohen <ohad@...ery.com>,
Linus Walleij <linus.walleij@...aro.org>,
virtualization@...ts.linux-foundation.org
Subject: Re: [PATCH repost] virtio: don't crash when device is buggy
"Michael S. Tsirkin" <mst@...hat.com> writes:
> Because of a sanity check in virtio_dev_remove, a buggy device can crash
> kernel. And in case of rproc it's userspace so it's not a good idea.
> We are unloading a driver so how bad can it be?
> Be less aggressive in handling this error: if it's a driver bug,
> warning once should be enough.
>
> Signed-off-by: Michael S. Tsirkin <mst@...hat.com>
>
> --
>
> 3.6 material?
I have already applied, this, but it's not for stable, since it's a
"theoretical bugfix". That check has been in there forever and noone
AFAIK has actually struck it.
Cheers,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists