linux-kernel - Re: [PATCH] Fix uninitialized variable in ath6kl ath6kl_sdio_enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <505C98A3.9060109@qca.qualcomm.com>
Date:	Fri, 21 Sep 2012 19:41:07 +0300
From:	Kalle Valo <kvalo@....qualcomm.com>
To:	Andi Kleen <andi@...stfloor.org>
CC:	<linux-wireless@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	ath6kl-devel <ath6kl-devel@...lcomm.com>
Subject: Re: [PATCH] Fix uninitialized variable in ath6kl ath6kl_sdio_enable_scatter

On 09/03/2012 11:15 PM, Andi Kleen wrote:
> gcc 4.8 warns
> 
> /backup/lsrc/git/linux-lto-2.6/drivers/net/wireless/ath/ath6kl/sdio.c:
> In function 'ath6kl_sdio_enable_scatter':
> /backup/lsrc/git/linux-lto-2.6/drivers/net/wireless/ath/ath6kl/sdio.c:748:16:
> warning: 'ret' may be used uninitialized in this function
> [-Wmaybe-uninitialized]
>   if (virt_scat || ret) {
>                 ^
> 
> The variable can indeed be uninitialized when the previous if branch is
> skipped. I just set it to zero for now. I'm not fully sure the fix is
> correct, maybe the || should be an && ? 

>From a quick look || should be correct, but of course I might be missing
something. I think your patch is correct way to fix this.

Thanks, applied to ath6kl.git. I just added "ath6kl:" prefix to the title.

Kalle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/