linux-kernel - Re: arch/x86/Kconfig: not select X86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20121025162937.GA38477@bingao-desk1.fm.intel.com>
Date:	Thu, 25 Oct 2012 09:29:38 -0700
From:	Bin Gao <bin.gao@...ux.intel.com>
To:	Ingo Molnar <mingo@...nel.org>
Cc:	x86@...nel.org, linux-kernel@...r.kernel.org,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, Len Brown <len.brown@...el.com>
Subject: Re: arch/x86/Kconfig: not select X86_MPPARSE when SFI is present

Yes, your suggested descriptions more match the change.
I'm sending a new patch for your review. Thanks.

-Bin

On Thu, Oct 25, 2012 at 09:57:52AM +0200, Ingo Molnar wrote:
> 
> * Bin Gao <bin.gao@...ux.intel.com> wrote:
> 
> > MPS tables are not needed for systems that have proper ACPI support.
> > This is also true for systems that have SFI in place.
> > 
> > So this patch is to exclude X86_MPPARSE when either ACPI or SFI is present.
> > 
> > Signed-off-by: Bin Gao <bin.gao@...el.com>
> > ---
> >  arch/x86/Kconfig |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> > index 46c3bff..b1494bd 100644
> > --- a/arch/x86/Kconfig
> > +++ b/arch/x86/Kconfig
> > @@ -310,7 +310,7 @@ config X86_X2APIC
> >  	  If you don't know what to do here, say N.
> >  
> >  config X86_MPPARSE
> > -	bool "Enable MPS table" if ACPI
> > +	bool "Enable MPS table" if ACPI || SFI
> >  	default y
> >  	depends on X86_LOCAL_APIC
> >  	---help---
> 
> The changelog does not seem to match the patch. Did you want to 
> say:
> 
>   " So this patch allows the configuration (turning off) of
>     CONFIG_X86_MPPARSE when either ACPI or SFI is present. "
> 
> ?
> 
> 	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/