linux-kernel - Re: [RFC PATCH] Fix abnormal rcu dynticks_nesting values related to async page fault

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFTL4hyzVLismy0ckx0Tu47EAgNn9WjAFEx=ptF5587-zp65hQ@mail.gmail.com>
Date:	Tue, 27 Nov 2012 17:51:12 +0100
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	Gleb Natapov <gleb@...hat.com>
Cc:	Li Zhong <zhong@...ux.vnet.ibm.com>,
	linux-next list <linux-next@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>, paulmck@...ux.vnet.ibm.com,
	sasha.levin@...cle.com, avi@...hat.com
Subject: Re: [RFC PATCH] Fix abnormal rcu dynticks_nesting values related to
 async page fault

2012/11/27 Gleb Natapov <gleb@...hat.com>:
> On Tue, Nov 27, 2012 at 04:56:30PM +0100, Frederic Weisbecker wrote:
>> 2012/11/27 Gleb Natapov <gleb@...hat.com>:
>> > For KVM_PV_REASON_PAGE_NOT_PRESENT it behaves like an exception.
>>
>> Ok.
>> There seem to be a bug in kvm_async_pf_task_wait(). Using
>> idle_cpu(cpu) to find out if the current task is the idle task may not
>> work if there is pending wake up. Me may schedule another task but
>> when that other task sleeps later we can't schedule back to idle until
>> the fault is completed.
>>
>> The right way is to use is_idle_task(current)
> But if there is pending wake up then scheduling to the waked up task is
> exactly what we want.

Ok, but what if that task goes to sleep soon after beeing scheduled
and there is no other task on the runqueue and the page fault has not
been handled yet? The only thing you can do is to schedule the idle
task. But the idle task is waiting for the fault completion so you
can't do that.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/