linux-kernel - Re: [PATCH v3.5] dw_dmac: return proper residue value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vf5ukEv=dp+RtaYHxfJ+vVDKTjmexh0teaJOOR9prR1ig@mail.gmail.com>
Date:	Fri, 25 Jan 2013 11:37:42 +0200
From:	Andy Shevchenko <andy.shevchenko@...il.com>
To:	Viresh Kumar <viresh.kumar@...aro.org>
Cc:	Vinod Koul <vinod.koul@...el.com>, linux-kernel@...r.kernel.org,
	spear-devel <spear-devel@...t.st.com>
Subject: Re: [PATCH v3.5] dw_dmac: return proper residue value

On Fri, Jan 25, 2013 at 11:30 AM, Viresh Kumar <viresh.kumar@...aro.org> wrote:
> On Fri, Jan 25, 2013 at 2:49 PM, Andy Shevchenko
> <andy.shevchenko@...il.com> wrote:
>> On Fri, Jan 25, 2013 at 11:07 AM, Viresh Kumar <viresh.kumar@...aro.org> wrote:
>>> Who is going to right on ctlhi/lo?
>
> Ahh, my English :( (/s/right/write)
>
>> dwc_do_single_block()
>>
>>> we write to ctlhi/lo only when we program new
>>> transfer. and that is not going to happen while we are in middle of a transfer.
>>
>> We have got a tasklet running inside tx_status call. Isn't possible?
>> tasklet runs scan_descriptors, that continues transfer in soft LLP mode.
>
> But we have just executed scan_descriptor() before this function and it doesn't
> look possible that transfer wasn't over then and inbetween these calls we got an
> interrupt, scheduled an tasklet and called dwc_do_single_block() :)

Yeah, the keyword is "look". 1 per million cases it could be true. I
think this discussion is going to the dead end.
Anyone else would like to argue for one or the other opinion?

I might obey your way with the commentary that with quite lower
possibility we could have an issue there.

-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/