linux-kernel - Re: pt_regs leak into userspace (was Re: [PATCH v3 20/71] ARC: Signal handling)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 15 Feb 2013 08:23:44 +0100
From:	Jonas Bonn <jonas.bonn@...il.com>
To:	Al Viro <viro@...iv.linux.org.uk>
Cc:	Vineet Gupta <Vineet.Gupta1@...opsys.com>,
	Arnd Bergmann <arnd@...db.de>,
	"linux-arch@...r.kernel.org" <linux-arch@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: pt_regs leak into userspace (was Re: [PATCH v3 20/71] ARC: Signal handling)

On 11 February 2013 15:07, Al Viro <viro@...iv.linux.org.uk> wrote:

> I'd suggest asking itanic folks; they do *not* put callee-saved stuff into
> sigcontext.  AFAICS, they don't have setcontext() implemented as a syscall
> at all - it's done as sigprocmask() + doing to callee-saved registers what
> longjmp() does.


Just to round off this discussion, after giving it some more thought I
agree that the case where you would need callee-saved registers
restored is probably rather pathological.  Any sane use of
get/set/swapcontext is manageable without this.

So, Vineet, I'm now convinced your approach is sound.  I will probably
amend the OpenRISC arch to behave similarly.  Consider your entire
patch Acked now.

/Jonas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/