linux-kernel - RE: [NEW DRIVER V4 0/7] DA9058 PMIC - please comment on this new driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <24DF37198A1E704D9811D8F72B87EB514191E2DC@NB-EX-MBX02.diasemi.com>
Date:	Tue, 16 Apr 2013 09:18:41 +0000
From:	"Opensource [Anthony Olech]" <anthony.olech.opensource@...semi.com>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	"Opensource [Anthony Olech]" <anthony.olech.opensource@...semi.com>
CC:	LKML <linux-kernel@...r.kernel.org>,
	David Dajun Chen <david.chen@...semi.com>,
	"Mark Brown (broonie@...nsource.wolfsonmicro.com)" 
	<broonie@...nsource.wolfsonmicro.com>
Subject: RE: [NEW DRIVER V4 0/7] DA9058 PMIC - please comment on this new
 driver

> -----Original Message-----
> From: Dmitry Torokhov [mailto:dmitry.torokhov@...il.com]
> Sent: 12 April 2013 19:07
> To: Opensource [Anthony Olech]
> Cc: LKML; Alessandro Zummo
> Subject: Re: [NEW DRIVER V4 0/7] DA9058 PMIC - please comment on this new driver
> On Friday, April 12, 2013 02:05:29 PM Anthony Olech wrote:
> > This is submission attempt number 4 to have this driver included in
> > the linux kernel source tree. This is the driver for the Dialog DA9058.
> > The DA9058 is a low power Power Management Integrated Circuit with
> > extra functionality. It is a Multi Function Device controlled only
> > from an I2C bus whose components can raise an interrupt request on a single IRQ line.
> > The driver for the DA9058 consists of a core (i2c) device driver that
> > instantiates the individual component device drivers for:
> > adc - 5 ADC channels
> > gpio - 2 available pins
> > onkey - 1 device
> 
> > This is almost exact copy of da9052_onkey, can they be merged together?
>
> Dmitry

Hi Dmitry,

it does look like the ONKEY component driver of the Dialog DA9058 PMIC is
functionally similar to other onkey drivers. Specifically those drivers that have
to poll for ONKEY de-assertion.

The reason why they are separate is that they are probed with different data
structures and they use a different wrapper to access the "regmap" API.
However, that is not a blocking issue, but it would mean re-writing the core
MFD component of all the affected drivers. Maybe the way forward is:

Is it possible to provide some "core" ONKEY API or functionality to handle the
commonality in a similar fashion to the regulator core as done by Mark Brown?

Tony Olech
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/