lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Fri, 26 Apr 2013 11:33:27 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	"Li, Fei" <fei.li@...el.com>
Cc:	"tglx@...utronix.de" <tglx@...utronix.de>,
	"mingo@...hat.com" <mingo@...hat.com>,
	"hpa@...or.com" <hpa@...or.com>, "x86@...nel.org" <x86@...nel.org>,
	"Liu, Chuansheng" <chuansheng.liu@...el.com>,
	"tomoki.sekiyama.qu@...achi.com" <tomoki.sekiyama.qu@...achi.com>,
	"suresh.b.siddha@...el.com" <suresh.b.siddha@...el.com>,
	"joe@...ches.com" <joe@...ches.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86: eliminate irq_mis_count counted in arch_irq_stat


* Li, Fei <fei.li@...el.com> wrote:

> > > Signed-off-by: Liu Chuansheng <chuansheng.liu@...el.com>
> > > Signed-off-by: Li Fei <fei.li@...el.com>
> > 
> > The patch looks good, but this is not a valid signoff sequence. If Liu
> > Chuansheng wrote this patch then his From: line should be included. If he
> > acked it, then it should be added as Acked-by.
> > 
> Hello Ingo,
>    Thanks for your quick feedback. 
> 
>    I add Chuansheng's signature basing on:
>    1> Chuansheng found such hole in code;
>    2> After discussion with Chuansheng, I wrote the patch;
>    3> Chuansheng also acked it.
>    
>    Do you think it's OK to add Chuansheng's signature in such case?
>    Or better suggestion?

Signed-off-by has a specific meaning, it typically means someone authored 
or as a maintainer forwarded the code (which did not happen here) - see 
the details in Documentation/SubmittingPatches, under this section:

  12) Sign your work

If Chuansheng found the bug, there's a Reported-by tag. If Chuansheng 
approves of the fix patch then there's Acked-by for that. If he tested it, 
then for that there's the Tested-by tag. You can also add several of those 
tags.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists