linux-kernel - Re: [PATCH] dmaengine: ste_dma40: Declare memcpy config as static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130621031000.GB23141@intel.com>
Date:	Fri, 21 Jun 2013 08:40:00 +0530
From:	Vinod Koul <vinod.koul@...el.com>
To:	Fabio Baltieri <fabio.baltieri@...aro.org>
Cc:	Linus Walleij <linus.walleij@...aro.org>,
	Lee Jones <lee.jones@...aro.org>,
	Srinidhi Kasagar <srinidhi.kasagar@...ricsson.com>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dmaengine: ste_dma40: Declare memcpy config as static

On Thu, Jun 20, 2013 at 11:17:39AM +0200, Fabio Baltieri wrote:
> Fix sparse warnings:
> 
> drivers/dma/ste_dma40.c:81:26: warning: symbol 'dma40_memcpy_conf_phy' was not declared. Should it be static?
> drivers/dma/ste_dma40.c:95:26: warning: symbol 'dma40_memcpy_conf_log' was not declared. Should it be static?
> 
> Signed-off-by: Fabio Baltieri <fabio.baltieri@...aro.org>
Acked-by: Vinod Koul <vinod.koul@...el.com>

I guess this would be dependent on recent ste_dma40 patches so best way is
Linus's tree, right?

--
~Vinod
> ---
> 
> Hi Linus,
> 
> just a quick sparse error fixup on the dma driver.
> 
> Thanks,
> Fabio
> 
>  drivers/dma/ste_dma40.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c
> index fa4f9a3..8f72085 100644
> --- a/drivers/dma/ste_dma40.c
> +++ b/drivers/dma/ste_dma40.c
> @@ -78,7 +78,7 @@ static int dma40_memcpy_channels[] = {
>  };
>  
>  /* Default configuration for physcial memcpy */
> -struct stedma40_chan_cfg dma40_memcpy_conf_phy = {
> +static struct stedma40_chan_cfg dma40_memcpy_conf_phy = {
>  	.mode = STEDMA40_MODE_PHYSICAL,
>  	.dir = DMA_MEM_TO_MEM,
>  
> @@ -92,7 +92,7 @@ struct stedma40_chan_cfg dma40_memcpy_conf_phy = {
>  };
>  
>  /* Default configuration for logical memcpy */
> -struct stedma40_chan_cfg dma40_memcpy_conf_log = {
> +static struct stedma40_chan_cfg dma40_memcpy_conf_log = {
>  	.mode = STEDMA40_MODE_LOGICAL,
>  	.dir = DMA_MEM_TO_MEM,
>  
> -- 
> 1.8.2
> 

-- 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/