lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 16 Jul 2013 16:39:32 -0700 From: Yinghai Lu <yinghai@...nel.org> To: "H. Peter Anvin" <hpa@...or.com> Cc: Kees Cook <keescook@...omium.org>, Steven Rostedt <rostedt@...dmis.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>, "the arch/x86 maintainers" <x86@...nel.org>, Seiji Aguchi <seiji.aguchi@....com>, Fenghua Yu <fenghua.yu@...el.com>, Frederic Weisbecker <fweisbec@...il.com>, "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>, Suresh Siddha <suresh.b.siddha@...el.com>, PaX Team <pageexec@...il.com> Subject: Re: [PATCH v5] x86: make sure IDT is page aligned On Tue, Jul 16, 2013 at 3:16 PM, H. Peter Anvin <hpa@...or.com> wrote: > On 07/16/2013 03:13 PM, Yinghai Lu wrote: >> >> ok, then should change >> >>> +/* No need to be aligned, but done to keep all IDTs defined the same way. */ >>> +gate_desc trace_idt_table[NR_VECTORS] __page_aligned_bss; >> >> ==> >> >>> +/* Only need to be cacheline aligned, but keep all IDTs defined the same way to be page aligned. */ >>> +gate_desc trace_idt_table[NR_VECTORS] __page_aligned_bss; > > It doesn't need to be cacheline aligned, either, to the best of my > knowledge. The former comment is more correct. ok. so the old code is just for optimization to keep it cacheline aligned? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists