linux-kernel - Re: [Ksummit-2013-discuss] [ATTEND] How to act on LKML (was: [ 00/19] 3.10.1-stable review)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1374017917.6458.103.camel@gandalf.local.home>
Date:	Tue, 16 Jul 2013 19:38:37 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Sarah Sharp <sarah.a.sharp@...ux.intel.com>
Cc:	Theodore Ts'o <tytso@....edu>, David Lang <david@...g.hm>,
	ksummit-2013-discuss@...ts.linuxfoundation.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Darren Hart <dvhart@...ux.intel.com>,
	Ingo Molnar <mingo@...nel.org>,
	Olivier Galibert <galibert@...ox.com>,
	stable <stable@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Willy Tarreau <w@....eu>
Subject: Re: [Ksummit-2013-discuss] [ATTEND] How to act on LKML (was: [
 00/19] 3.10.1-stable review)

On Tue, 2013-07-16 at 16:12 -0700, Sarah Sharp wrote:

> > What problem exactly are we trying to solve here?
> 
> Personal attacks are not cool Steve.

I never said it was. But no matter what we do, people *will* be
offended. Can't help that.

>   Some people simply don't care if a
> verbal tirade is directed at them.  Others do not want anyone to attack
> them personally, but they're fine with people attacking their code.

If all you do is send code, then that's all that will happen. If you
start dictating policy, then it may be directed at you.

> 
> Bystanders that don't understand the kernel community structure are
> discouraged from contributing because they don't want to be verbally
> abused, and they really don't want to see either personal attacks or
> intense belittling, demeaning comments about code.

I wonder how true this is. I don't mean just any bystander, but people
that actually have code they could submit.

I'll admit that when I first started sending patches to LKML, I was
terrified. Not because I was afraid of being scolded, but because I was
afraid that what I sent wasn't good. It was a true judgment of my work.
I was prettified. Sure, I wouldn't have liked being insulted, but as
long as there was backing of why my work sucked I would be OK with it. I
actually had a rather good response to my work and I hung around.

But is there code existing out in the world that isn't in because people
are afraid of being insulted? Or afraid of their code being insulted? I
was the latter, and as we all seem to agree, the insulting of code is
what we want to keep.

> 
> In order to make our community better, we need to figure out where the
> baseline of "good" behavior is.

"community" has all sorts of behavior. The question is, is there really
a problem here? Sure some people don't like it, but they are still here.
Do you plan on leaving the Linux community if Linus doesn't change?

Now that would be a shame if you did, because you are a talented
developer. But I've never seen people insult you directly on LKML. I
don't know about private emails, but that's not the topic here.

>   We need to define what behavior we want
> from both maintainers and patch submitters.  E.g. "No regressions" and
> "don't break userspace"

Yes, those do need to be documented.

>  and "no personal attacks".

I actually disagree with this. What I would say this instead: "try to
keep it technical and focus on the code. If you are upset at someone,
think twice before hitting send. But if you really think this is the
only way to deal with the situation, then that's your call, and you get
to deal with the consequences."

I don't think changing peoples behavior is going to work. It wont. You
don't want to change who you are, others don't want to change who they
are. Deal with it. But what we can do is just try to educate people on
what policies are needed to be a maintainer and code submitter (there is
documentation already on some of this), and then point it to people. If
people continue to ignore those after being shown, then yes, personal
attacks are then in order.

>   That needs to be
> written down somewhere, and it isn't.  If it's documented somewhere,
> point me to the file in Documentation.  Hint: it's not there.

Well, SubmittingPatches is there, but we should have a MaintainerRules
or something.

> 
> That is the problem.

We can always use better documentation.

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/