linux-kernel - Re: [Ksummit-2013-discuss] [ATTEND] How to act on LKML (was: [ 00/19] 3.10.1-stable review)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130717074644.GA5585@mwanda>
Date:	Wed, 17 Jul 2013 10:46:44 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Guenter Roeck <linux@...ck-us.net>
Cc:	Sarah Sharp <sarah.a.sharp@...ux.intel.com>,
	ksummit-2013-discuss@...ts.linuxfoundation.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Darren Hart <dvhart@...ux.intel.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Willy Tarreau <w@....eu>, stable <stable@...r.kernel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Ingo Molnar <mingo@...nel.org>
Subject: Re: [Ksummit-2013-discuss] [ATTEND] How to act on LKML (was: [
 00/19] 3.10.1-stable review)

On Mon, Jul 15, 2013 at 04:15:55PM -0700, Guenter Roeck wrote:
> "Your code breaks the build for every platform. Would you please kindly
> consider fixing it ?"

Something like this: https://lists.launchpad.net/ac100/msg01040.html

"small typo here."

Marc, was obviously dripping with sarcasm when he wrote that, but it
was completely lost on the patch submitter.  I've done that too
where I asked "Are you sure you want to call schedule() while
holding a spinlock()?"  It ended up becoming flame fest and it could
have been avoided if I had said, "You are not allowed to call
shedule() while holding a spinlock."

Also instead of saying "Your code is crap", I prefer to say "This
patch is crap."  I suspect the submitters secretly know I think they
are crap too along with their code, but it's important to maintain
the facade.  :)

One other thing which is tricky is if there is someone whose patches
are so worthless it's just a waste of time.  There have been a
couple times where I've told people to stop submitting patches until
they have a few more years of programming experience.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/