linux-kernel - Re: [PATCH v2 3/4] arm: dts: Add USB phy nodes for AM33XX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51E98897.6050105@linutronix.de>
Date:	Fri, 19 Jul 2013 20:42:31 +0200
From:	Sebastian Andrzej Siewior <bigeasy@...utronix.de>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
CC:	George Cherian <george.cherian@...com>, linux-usb@...r.kernel.org,
	balbi@...com, linux-kernel@...r.kernel.org,
	gregkh@...uxfoundation.org, linux-omap@...r.kernel.org,
	kishon@...com
Subject: Re: [PATCH v2 3/4] arm: dts: Add USB phy nodes for AM33XX

On 07/19/2013 08:33 PM, Sergei Shtylyov wrote:
> Hello.

Hello,

>> usb: usb@...00000 {
>>     compatible = "ti,am33xx-usb";
>>     
>>     usb0_phy: phy@...01300 {
>>         compatible = "ti,am335x-usb-phy";
>>     }
>>     usb0: usb@...01000 {
>>         musb0: usb@...01400 {
>>             compatible = "mg,musbmhdrc";
>>         }
>>     }
>>     usb1_phy: phy@...02300 {
>>         compatible = "ti,am335x-usb-phy";
>>     }
>>     usb1: usb@...02000 {
>>         musb1: usb@...02400 {
>>             compatible = "mg,musbmhdrc";
>>         }
>>     }
>> }
> 
>> And you want usb0_phy to be child of usb0? In the TRM they are all in
>> the same block.
> 
>    Ah, the fact that PHYs didn't have the "reg" property got me muddled,
> I didn't pay attention to the address part of the node names... BTW,
> where is the "reg" prop?

I skipped it for the general idea. I planned to repost is today but I
messed up dsps and need to get it working first…

> I see PHYs share the address space with
> "omap-control-usb@...10620" device -- what's the point with this?

I decided to get rid of this. Both phys have 8 bytes (2 registers)
which are exclusive for them.
There is one register for the wakeup which is shared by both.
I changed this to limit it only to the 8bytes per phy. I care about
wakeup later - hopefully George will take care of this :)

> 
>> Sebastian
> 
> WBR, Sergei
> 
Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/