linux-kernel - Re: [PATCH] irq: enable suspended EARLY_RESUME irqs forcefully if not resumed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <51F91AEE.1030900@nvidia.com>
Date:	Wed, 31 Jul 2013 19:40:54 +0530
From:	Laxman Dewangan <ldewangan@...dia.com>
To:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
	Thomas Gleixner <tglx@...utronix.de>
CC:	LKML <linux-kernel@...r.kernel.org>,
	"Rafael J. Wysocki" <rjw@...k.pl>
Subject: Re: [PATCH] irq: enable suspended EARLY_RESUME irqs forcefully if
 not resumed

On Tuesday 23 July 2013 01:02 AM, Konrad Rzeszutek Wilk wrote:
> On Mon, Jul 22, 2013 at 11:49:34AM -0400, Konrad Rzeszutek Wilk wrote:
>> On Fri, Jul 19, 2013 at 05:29:16PM +0200, Thomas Gleixner wrote:
>>> On Tue, 9 Jul 2013, Laxman Dewangan wrote:
>>>> When system enters into suspend, it disable all irqs in single
>>>> function call. This disables EARLY_RESUME irqs also along with
>>>> normal irqs.
>>>>
>>>> The EARLY_RESUME irqs get enabled in sys_core_ops->resume and
>>>> non-EARLY_RESUME irqs get enabled in normal system resume path.
>>>>
>>>> When suspend_noirq failed or suspend is aborted for any reason,
>>>> the EARLY_RESUME irqs do not get enabled as sys_core_ops->resume()
>>>> call did not happen. It only enables the non-EARLY_RESUME irqs in normal
>>>> disable for remaining life of system.
>>>>
>>>> Add checks on normal irq_resume() whether EARLY_RESUME irqs have been
>>>> enabled or not and if not then enable it forcefully.
>>>   
>>>>   
>>>> +static bool early_resume_irq_suspended;
>>>> +
>>> Instead of doing that status dance, we could simply reenable all
>>> interrupts in irq_resume(). There's nothing wrong to unmask the few
>>> IRQF_EARLY_RESUME interrupts again.
>>>
>>> Just the XEN ones might be upset. Konrad ?
>> It should not. I did test it and it ran just fine throught the
>> gauntlet test - but let me check it with me looking at the console.
> It is good. You can add an Acked-by-and-Tested-by from me if you would
> like. Thanks!

Hi Thomas,
Can your change be applied now if this is good? I am fine with the 
following change.
If you want, I can send this change through patch or you can take my 
Ack, whatever is good.

Acked-by: Laxman Dewangan <ldewangan@...dia.com>

>>> Thanks,
>>>
>>> 	tglx
>>>
>>> Index: linux-2.6/kernel/irq/pm.c
>>> ===================================================================
>>> --- linux-2.6.orig/kernel/irq/pm.c
>>> +++ linux-2.6/kernel/irq/pm.c
>>> @@ -50,7 +50,7 @@ static void resume_irqs(bool want_early)
>>>   		bool is_early = desc->action &&
>>>   			desc->action->flags & IRQF_EARLY_RESUME;
>>>   
>>> -		if (is_early != want_early)
>>> +		if (!is_early && want_early)
>>>   			continue;
>>>   
>>>   		raw_spin_lock_irqsave(&desc->lock, flags);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/