linux-kernel - Re: [PATCH 0/9] target: Add support for COMPARE_AND

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5213E72F.6070309@interlog.com>
Date:	Tue, 20 Aug 2013 18:01:19 -0400
From:	Douglas Gilbert <dgilbert@...erlog.com>
To:	"Nicholas A. Bellinger" <nab@...ux-iscsi.org>
CC:	Christoph Hellwig <hch@....de>,
	"Nicholas A. Bellinger" <nab@...erainc.com>,
	target-devel <target-devel@...r.kernel.org>,
	lkml <linux-kernel@...r.kernel.org>,
	linux-scsi <linux-scsi@...r.kernel.org>,
	Hannes Reinecke <hare@...e.de>,
	Martin Petersen <martin.petersen@...cle.com>,
	Chris Mason <chris.mason@...ionio.com>,
	James Bottomley <JBottomley@...allels.com>
Subject: Re: [PATCH 0/9] target: Add support for COMPARE_AND_WRITE (VAAI)
 emulation

On 13-08-20 05:53 PM, Nicholas A. Bellinger wrote:
> On Tue, 2013-08-20 at 23:29 +0200, Christoph Hellwig wrote:
>> On Tue, Aug 20, 2013 at 08:07:51PM +0000, Nicholas A. Bellinger wrote:
>>>
>>> It's also currently lacking the necessary sychronization between I/O
>>> submission of COMPARE_AND_WRITE verify instance and write instance
>>> user data, which is still being worked on in order to avoid additional
>>> overhead in the main I/O fast path.
>>
>> I don't think merging such a non-conforming implementation makes any sense.
>>
>
> Yes, I don't intend to merge anything that's not fully functional.
>
> The idea was to get review going on these pieces first.  I'll be posting
> an PATCH-v2 to complete the implementation over the next days.
>
>> Also for a complex command like this with all it's race potential I would
>> really like to see some test cases to go along with it.
>>
>
> Yes, Eric @ PureStorage has a sg_compare_write that I'm using to test
> this.  It's probably about time that this be included in upstream
> sg3-utils too..

Changelog for sg3_utils-1.35 [20130117] [svn: r476]
   - sg_compare_and_write: new utility
...

So it has been released for 6 months. Also version 1.36
has been released since then so you might check more
often. Does Eric's version have any improvements over the
version already in sg3_utils? [Apart from a shorter name ...]

Doug Gilbert


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/