linux-kernel - Re: [PATCH 3/3] video: xilinxfb: Simplify error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 16 Sep 2013 12:33:04 +0200
From:	Michal Simek <monstr@...str.eu>
To:	Tomi Valkeinen <tomi.valkeinen@...com>
CC:	Michal Simek <michal.simek@...inx.com>,
	linux-kernel@...r.kernel.org,
	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	linux-fbdev@...r.kernel.org
Subject: Re: [PATCH 3/3] video: xilinxfb: Simplify error path

On 09/16/2013 11:51 AM, Tomi Valkeinen wrote:
> On 12/09/13 08:54, Michal Simek wrote:
> 
>> @@ -394,16 +382,12 @@ static int xilinxfb_release(struct device *dev)
>>  	/* Turn off the display */
>>  	xilinx_fb_out32(drvdata, REG_CTRL, 0);
>>
>> -	/* Release the resources, as allocated based on interface */
>> -	if (drvdata->flags & BUS_ACCESS_FLAG)
>> -		devm_iounmap(dev, drvdata->regs);
>>  #ifdef CONFIG_PPC_DCR
>> -	else
>> +	/* Release the resources, as allocated based on interface */
>> +	if (!(drvdata->flags & BUS_ACCESS_FLAG))
>>  		dcr_unmap(drvdata->dcr_host, drvdata->dcr_len);
>>  #endif
> 
> I might be mistaken, and it's not strictly part of this series, but
> shouldn't dcr_unmap be called somewhere else also, if the probe fails?

yes. It should.

Thanks,
Michal

-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform



Download attachment "signature.asc" of type "application/pgp-signature" (264 bytes)