linux-kernel - Re: [PATCH v1 5/6] bitops: Introduce BIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <523B2F57.2050504@linux.intel.com>
Date:	Thu, 19 Sep 2013 10:07:35 -0700
From:	Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
To:	Borislav Petkov <bp@...en8.de>
CC:	linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
	gregkh@...uxfoundation.org, len.brown@...el.com, rjw@...k.pl,
	arjan@...ux.intel.com, jacob.jun.pan@...ux.intel.com
Subject: Re: [PATCH v1 5/6] bitops: Introduce BIT_ULL

On 09/19/2013 09:48 AM, Borislav Petkov wrote:
> On Thu, Sep 19, 2013 at 09:00:34AM -0700, Srinivas Pandruvada wrote:
>> Adding BIT(x) equivalent for unsigned long long type, BIT_ULL(x).
>>
>> Suggested-by: Joe Perches <joe@...ches.com>
>> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
>> Signed-off-by: Jacob Pan <jacob.jun.pan@...ux.intel.com>
>> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
>> ---
>>   include/linux/bitops.h | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/include/linux/bitops.h b/include/linux/bitops.h
>> index a3b6b82..34e9e94 100644
>> --- a/include/linux/bitops.h
>> +++ b/include/linux/bitops.h
>> @@ -4,6 +4,7 @@
>>   
>>   #ifdef	__KERNEL__
>>   #define BIT(nr)			(1UL << (nr))
>> +#define BIT_ULL(nr)		(1ULL << (nr))
> We already have BIT_64 for that.
>
The current definition for BIT_64 is in arch/x86/include/asm/bitops.h. I 
feel it should be applicable for all architectures and move to some 
common file.

Thanks,
Srinivas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/