| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <52435B05.9030201@linaro.org> Date: Wed, 25 Sep 2013 23:52:05 +0200 From: Daniel Lezcano <daniel.lezcano@...aro.org> To: Viresh Kumar <viresh.kumar@...aro.org>, rjw@...k.pl CC: linaro-kernel@...ts.linaro.org, patches@...aro.org, linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 08/21] cpuidle: use cpuidle_disabled() instead of "off" On 09/22/2013 03:21 AM, Viresh Kumar wrote: > We have a routine for getting value of "off", better call that instead of using > "off" directly. We are in the fast path, I am not sure invoking a function here is better than using directly the static variable. > Signed-off-by: Viresh Kumar <viresh.kumar@...aro.org> > --- > drivers/cpuidle/cpuidle.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c > index 8c91bad..aec9029 100644 > --- a/drivers/cpuidle/cpuidle.c > +++ b/drivers/cpuidle/cpuidle.c > @@ -119,7 +119,7 @@ int cpuidle_idle_call(void) > struct cpuidle_driver *drv; > int next_state, entered_state; > > - if (off) > + if (cpuidle_disabled()) > return -ENODEV; > > if (!initialized) > -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists