linux-kernel - Re: [PATCH 4/5] sched: Refactor iowait accounting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131019160235.GA13534@localhost.localdomain>
Date:	Sat, 19 Oct 2013 18:02:37 +0200
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	Oleg Nesterov <oleg@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Fernando Luis Vazquez Cao <fernando_b1@....ntt.co.jp>,
	Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Arjan van de Ven <arjan@...ux.intel.com>
Subject: Re: [PATCH 4/5] sched: Refactor iowait accounting

On Sat, Oct 19, 2013 at 05:35:35PM +0200, Peter Zijlstra wrote:
> On Sat, Oct 19, 2013 at 05:17:20PM +0200, Frederic Weisbecker wrote:
> > +u64 get_cpu_iowait_time_us(int cpu, u64 *last_update_time)
> > +{
> > +	ktime_t iowait, delta = { .tv64 = 0 };
> > +	struct rq *rq = cpu_rq(cpu);
> > +	ktime_t now = ktime_get();
> > +	unsigned int seq;
> > +
> > +	do {
> > +		seq = read_seqbegin(&rq->iowait_lock);
> > +		if (rq->nr_iowait)
> > +			delta = ktime_sub(now, rq->iowait_start);
> > +		iowait = ktime_add(rq->iowait_time, delta);
> > +	} while (read_seqretry(&rq->iowait_lock, seq));
> > +
> > +	if (last_update_time)
> > +		*last_update_time = ktime_to_us(now);
> > +
> > +	return ktime_to_us(iowait);
> > +}
> > +EXPORT_SYMBOL_GPL(get_cpu_iowait_time_us);
> > +
> > +static void cpu_iowait_start(struct rq *rq)
> > +{
> > +	write_seqlock(&rq->iowait_lock);
> > +	if (!rq->nr_iowait++)
> > +		rq->iowait_start = ktime_get();
> > +	write_sequnlock(&rq->iowait_lock);
> > +}
> > +
> > +static void cpu_iowait_end(struct rq *rq)
> > +{
> > +	ktime_t delta;
> > +	write_seqlock(&rq->iowait_lock);
> > +	if (!--rq->nr_iowait) {
> > +		delta = ktime_sub(ktime_get(), rq->iowait_start);
> > +		rq->iowait_time = ktime_add(rq->iowait_time, delta);
> > +	}
> > +	write_sequnlock(&rq->iowait_lock);
> > +}
> 
> Yeah, so using ktime_get() for this is completely insane ;-)

Woops, yeah I clearly overlooked that while moving the code :)
local_clock() should be fine.

> 
> I just had a look at delayacct; wth wrote that crap; that too uses
> gtod.

I can't find where it does that. kernel/delayacct.c doesn't seem to at least.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/