linux-kernel - Re: [PATCH v6 6/7] arm64, jump label: optimize jump label implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131213105223.664f960b@gandalf.local.home>
Date:	Fri, 13 Dec 2013 10:52:23 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	Will Deacon <will.deacon@....com>, Jiang Liu <liuj97@...il.com>,
	Catalin Marinas <Catalin.Marinas@....com>,
	Sandeepa Prabhu <sandeepa.prabhu@...aro.org>,
	AKASHI Takahiro <takahiro.akashi@...aro.org>,
	Marc Zyngier <Marc.Zyngier@....com>,
	Mark Rutland <Mark.Rutland@....com>,
	Arnd Bergmann <arnd@...db.de>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v6 6/7] arm64, jump label: optimize jump label
 implementation

On Fri, 13 Dec 2013 10:50:23 -0500
Steven Rostedt <rostedt@...dmis.org> wrote:

> On Fri, 13 Dec 2013 15:41:04 +0000
> Will Deacon <will.deacon@....com> wrote:
> 
> > > +#include <linux/kernel.h>
> > > +#include <linux/jump_label.h>
> > > +#include <asm/jump_label.h>
> > > +#include <asm/insn.h>
> > > +
> > > +#ifdef HAVE_JUMP_LABEL
> > 
> > Slightly worrying... this should be CONFIG_HAVE_JUMP_LABEL, right? How did
> > you manage to test this code?
> 
> In <linux/jump_label.h> we have:
> 
> #if defined(CC_HAVE_ASM_GOTO) && defined(CONFIG_JUMP_LABEL)
> 
> [...]
> 
> # include <asm/jump_label.h>

This also makes the include of <asm/jump_label.h> in the C file
redundant.

-- Steve

> # define HAVE_JUMP_LABEL
> #endif	/* CC_HAVE_ASM_GOTO && CONFIG_JUMP_LABEL */
> 
> 
> -- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/