linux-kernel - Re: [PATCH] Staging: ced1401: fix coding style in ced

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140113235650.GA23380@kroah.com>
Date:	Mon, 13 Jan 2014 15:56:50 -0800
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Pol Eyschen <poleyschen@...il.com>
Cc:	sachin.kamat@...aro.org, jack@...e.cz, ufimtseva@...il.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	Pol Eyschen <poleyschen@...mail.com>
Subject: Re: [PATCH] Staging: ced1401: fix coding style in ced_ioc.c

On Mon, Jan 13, 2014 at 08:41:40PM +0100, Pol Eyschen wrote:
> From: Pol Eyschen <poleyschen@...mail.com>
> 
> All comments fixed to match the kernel coding style.
> 
> Signed-off-by: Pol Eyschen <poleyschen@...il.com>
> ---
>  drivers/staging/ced1401/ced_ioc.c |  382 ++++++++++++++++++++++++-------------
>  1 file changed, 249 insertions(+), 133 deletions(-)
> 
> diff --git a/drivers/staging/ced1401/ced_ioc.c b/drivers/staging/ced1401/ced_ioc.c
> index 62efd74..e5172cb 100644
> --- a/drivers/staging/ced1401/ced_ioc.c
> +++ b/drivers/staging/ced1401/ced_ioc.c
> @@ -41,7 +41,8 @@ static void FlushOutBuff(DEVICE_EXTENSION *pdx)
>  {
>  	dev_dbg(&pdx->interface->dev, "%s currentState=%d", __func__,
>  		pdx->sCurrentState);
> -	if (pdx->sCurrentState == U14ERR_TIME)	/* Do nothing if hardware in trouble */
> +	if (pdx->sCurrentState == U14ERR_TIME)
> +		/* Do nothing if hardware in trouble */
>  		return;

Please wrap stuff like this in { } to not confuse people.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/