linux-kernel - Re: [PATCH] Staging: ced1401: fix coding style in ced

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1389665978.24849.27.camel@joe-AO722>
Date:	Mon, 13 Jan 2014 18:19:38 -0800
From:	Joe Perches <joe@...ches.com>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	Pol Eyschen <poleyschen@...il.com>, sachin.kamat@...aro.org,
	jack@...e.cz, ufimtseva@...il.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org, Pol Eyschen <poleyschen@...mail.com>
Subject: Re: [PATCH] Staging: ced1401: fix coding style in ced_ioc.c

On Mon, 2014-01-13 at 15:56 -0800, Greg KH wrote:
> On Mon, Jan 13, 2014 at 08:41:40PM +0100, Pol Eyschen wrote:
[]
> > diff --git a/drivers/staging/ced1401/ced_ioc.c b/drivers/staging/ced1401/ced_ioc.c
[]
> > @@ -41,7 +41,8 @@ static void FlushOutBuff(DEVICE_EXTENSION *pdx)
> >  {
> >  	dev_dbg(&pdx->interface->dev, "%s currentState=%d", __func__,
> >  		pdx->sCurrentState);
> > -	if (pdx->sCurrentState == U14ERR_TIME)	/* Do nothing if hardware in trouble */
> > +	if (pdx->sCurrentState == U14ERR_TIME)
> > +		/* Do nothing if hardware in trouble */
> >  		return;
> 
> Please wrap stuff like this in { } to not confuse people.

Yes please, or maybe put the comment on the return line like:

	if (pdx->sCurrentState == U14ERR_TIME)
		return;			/* Do nothing if hardware in trouble */

or above the test like:

	/* Do nothing if hardware in trouble */
	if (pdx->sCurrentState == U14ERR_TIME)
		return;



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/