linux-kernel - Re: [PATCH 3/3] pinctrl: single: fix infinite loop caused by bad mask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdY=9Ebo+02wHPVhLB+1o=7zXJFKR-ieotY=U58Ubz44-Q@mail.gmail.com>
Date:	Wed, 15 Jan 2014 08:32:22 +0100
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Tomi Valkeinen <tomi.valkeinen@...com>,
	Haojian Zhuang <haojian.zhuang@...aro.org>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/3] pinctrl: single: fix infinite loop caused by bad mask

On Thu, Jan 9, 2014 at 1:50 PM, Tomi Valkeinen <tomi.valkeinen@...com> wrote:

> commit 4e7e8017a80e1 (pinctrl: pinctrl-single:
> enhance to configure multiple pins of different modules) improved
> support for pinctrl-single,bits option, but also caused a regression
> in parsing badly configured mask data.
>
> If the masks in DT data are not quite right,
> pcs_parse_bits_in_pinctrl_entry() can end up in an infinite loop,
> trashing memory at the same time.
>
> Add a check to verify that each loop actually removes bits from the
> 'mask', so that the loop can eventually end.
>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@...com>
> Acked-by: Tony Lindgren <tony@...mide.com>

Patch applied.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/