linux-kernel - Re: [PATCH] KVM: SVM: fix NMI window after iret

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140117202950.GA10616@hpx.cz>
Date:	Fri, 17 Jan 2014 21:29:51 +0100
From:	Radim Krčmář <rkrcmar@...hat.com>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	linux-kernel@...r.kernel.org, kvm@...r.kernel.org, joro@...tes.org,
	pbonzini@...hat.com, stable@...r.kernel.org
Subject: Re: [PATCH] KVM: SVM: fix NMI window after iret

2014-01-17 12:18-0800, Greg KH:
> On Fri, Jan 17, 2014 at 08:52:42PM +0100, Radim Krčmář wrote:
> > We should open NMI window right after an iret, but SVM exits before it.
> > We wanted to single step using the trap flag and then open it.
> > (or we could emulate the iret instead)
> > We don't do it since commit 3842d135ff2 (likely), because the iret exit
> > handler does not request an event, so NMI window remains closed until
> > the next exit.
> > 
> > Fix this by making KVM_REQ_EVENT request in the iret handler.
> > 
> > Signed-off-by: Radim Krčmář <rkrcmar@...hat.com>
> > ---
> >  (btw. kvm-unit-tests weren't executed on SVM since Nov 2010, at least)
> > 
> >  arch/x86/kvm/svm.c | 1 +
> >  1 file changed, 1 insertion(+)
> 
> 
> <formletter>
> 
> This is not the correct way to submit patches for inclusion in the
> stable kernel tree.  Please read Documentation/stable_kernel_rules.txt
> for how to do this properly.
> 
> </formletter>

Welp, at the last second, I decided it is not that critical to have it
in stable and forgot to clean the git-send-email command line too.

Please ignore this patch in stable.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/