linux-kernel - Re: [lm-sensors] lm90 driver no longer working on PCs in 3.13

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52E6951C.60609@wwwdotorg.org>
Date:	Mon, 27 Jan 2014 10:19:24 -0700
From:	Stephen Warren <swarren@...dotorg.org>
To:	Mark Brown <broonie@...nel.org>, Guenter Roeck <linux@...ck-us.net>
CC:	Jean Delvare <khali@...ux-fr.org>,
	Liam Girdwood <lgirdwood@...il.com>, Wei Ni <wni@...dia.com>,
	linux-kernel@...r.kernel.org,
	LM Sensors <lm-sensors@...sensors.org>
Subject: Re: [lm-sensors] lm90 driver no longer working on PCs in 3.13

On 01/26/2014 04:51 PM, Mark Brown wrote:
> On Sun, Jan 26, 2014 at 02:04:06PM -0800, Guenter Roeck wrote:
> 
>> I think I have a better idea: Surround the regulator code, or at least
>> its error handling, in the lm90 driver with
> 
>> 	if (IS_ENABLED(CONFIG_OF)) {
>> 	}
> 
>> Would that be ok ? If yes I'll submit a patch. I'll do the same in
>> another driver I am working on.
> 
> That's not going to have the desired effect in cases where DT is built
> into the kernel but not in use on the current system (which is a
> configuration that gets used) ...

The solution to that particular aspect of the problem is the following:

if (of_have_populated_dt()) {
	...

which is a run-time rather than compile-time test.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/