lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 7 Feb 2014 13:04:47 -0800 (PST) From: David Rientjes <rientjes@...gle.com> To: Rashika Kheria <rashika.kheria@...il.com> cc: linux-kernel@...r.kernel.org, Andrew Morton <akpm@...ux-foundation.org>, Rik van Riel <riel@...hat.com>, "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>, Jiang Liu <jiang.liu@...wei.com>, Michel Lespinasse <walken@...gle.com>, linux-mm@...ck.org, josh@...htriplett.org Subject: Re: [PATCH 9/9] mm: Remove ifdef condition in include/linux/mm.h On Fri, 7 Feb 2014, Rashika Kheria wrote: > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 1cedd00..5f8348f 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -1589,10 +1589,8 @@ static inline int __early_pfn_to_nid(unsigned long pfn) > #else > /* please see mm/page_alloc.c */ > extern int __meminit early_pfn_to_nid(unsigned long pfn); > -#ifdef CONFIG_HAVE_ARCH_EARLY_PFN_TO_NID > /* there is a per-arch backend function. */ > extern int __meminit __early_pfn_to_nid(unsigned long pfn); > -#endif /* CONFIG_HAVE_ARCH_EARLY_PFN_TO_NID */ > #endif > > extern void set_dma_reserve(unsigned long new_dma_reserve); Wouldn't it be better to just declare the __early_pfn_to_nid() in mm/page_alloc.c to be static? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists