linux-kernel - Re: [PATCH] Staging: speakup: buffers: Fixed a return value coding style issue.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140227164751.GU26722@mwanda>
Date:	Thu, 27 Feb 2014 19:47:51 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Reza Snowdon <rs@...e.me.uk>
Cc:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	speakup@...ille.uwo.ca, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: speakup: buffers: Fixed a return value coding
 style issue.

On Thu, Feb 27, 2014 at 04:26:42PM +0000, Reza Snowdon wrote:
> Fixed a coding style issue.
> 
> Signed-off-by: Reza Snowdon <rs@...e.me.uk>
> ---
>  drivers/staging/speakup/buffers.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/speakup/buffers.c b/drivers/staging/speakup/buffers.c
> index 382973e..8d7caa7 100644
> --- a/drivers/staging/speakup/buffers.c
> +++ b/drivers/staging/speakup/buffers.c
> @@ -55,7 +55,8 @@ static int synth_buffer_free(void)
>  
>  int synth_buffer_empty(void)
>  {
> -	return (buff_in == buff_out);
> +	int buff_comparison = (buff_in == buff_out);
> +	return buff_comparison;

This isn't simpler than the original code.

Just do:

int synth_buffer_empty(void)
{
	return buff_in == buff_out;
}

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/