linux-kernel - Re: [PATCH v2] ASoC: cs42888: Add codec driver support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <531F320E.70605@metafoo.de>
Date:	Tue, 11 Mar 2014 16:55:58 +0100
From:	Lars-Peter Clausen <lars@...afoo.de>
To:	Brian Austin <brian.austin@...rus.com>
CC:	Nicolin Chen <Guangyu.Chen@...escale.com>, broonie@...nel.org,
	Paul.Handrigan@...rus.com, robh+dt@...nel.org, pawel.moll@....com,
	mark.rutland@....com, ijc+devicetree@...lion.org.uk,
	galak@...eaurora.org, rob@...dley.net, lgirdwood@...il.com,
	grant.likely@...aro.org, devicetree@...r.kernel.org,
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
	alsa-devel@...a-project.org
Subject: Re: [PATCH v2] ASoC: cs42888: Add codec driver support

On 03/11/2014 04:41 PM, Brian Austin wrote:
>
> On Tue, 11 Mar 2014, Nicolin Chen wrote:
>
>> This patch adds support for the Cirrus Logic CS42888 Audio CODEC that
>> has four 24-bit A/D and eight 24-bit D/A converters.
>>
>> [ CS42888 supports both I2C and SPI control ports. As initial patch,
>>  this patch only adds the support for I2C. ]
>>
>> Signed-off-by: Nicolin Chen <Guangyu.Chen@...escale.com>
>> ---
> So WRT the CS42888, this is one device in a series of 2 devices that are
> register compatible with the only difference being that the CS42488 has 2
> extra ADC's. Same die and same DeviceID.
>
> Would it make more sense to submit the driver with the extra ADC's to make
> it feature complete for both devices? Wouldn't be odd to have 2 drivers that
> do the same for 98% of the code.

This should be in one driver. But support for the second device can always 
be added in a follow up patch.

- Lars

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/