linux-kernel - Re: [PATCH v2] ASoC: cs42888: Add codec driver support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140311184606.GW28112@sirena.org.uk>
Date:	Tue, 11 Mar 2014 18:46:06 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Lars-Peter Clausen <lars@...afoo.de>
Cc:	Brian Austin <brian.austin@...rus.com>,
	Nicolin Chen <Guangyu.Chen@...escale.com>,
	Paul.Handrigan@...rus.com, robh+dt@...nel.org, pawel.moll@....com,
	mark.rutland@....com, ijc+devicetree@...lion.org.uk,
	galak@...eaurora.org, rob@...dley.net, lgirdwood@...il.com,
	grant.likely@...aro.org, devicetree@...r.kernel.org,
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
	alsa-devel@...a-project.org
Subject: Re: [PATCH v2] ASoC: cs42888: Add codec driver support

On Tue, Mar 11, 2014 at 04:55:58PM +0100, Lars-Peter Clausen wrote:
> On 03/11/2014 04:41 PM, Brian Austin wrote:

> >So WRT the CS42888, this is one device in a series of 2 devices that are
> >register compatible with the only difference being that the CS42488 has 2
> >extra ADC's. Same die and same DeviceID.

> >Would it make more sense to submit the driver with the extra ADC's to make
> >it feature complete for both devices? Wouldn't be odd to have 2 drivers that
> >do the same for 98% of the code.

> This should be in one driver. But support for the second device can
> always be added in a follow up patch.

Yes, we can add support later.  It might be helpful to name the driver
with some generic name I guess.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)