[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20140517192253.GC15585@mwanda>
Date: Sat, 17 May 2014 22:22:53 +0300
From: Dan Carpenter <dan.carpenter@...cle.com>
To: Antti Palosaari <crope@....fi>
Cc: Martin Kepplinger <martink@...teo.de>, gregkh@...uxfoundation.org,
Devin Heitmueller <dheitmueller@...nellabs.com>,
devel@...verdev.osuosl.org, linux-media@...r.kernel.org,
linux-kernel@...r.kernel.org, m.chehab@...sung.com
Subject: Re: [PATCHv2] staging: media: as102: replace custom dprintk() with
dev_dbg()
On Sat, May 17, 2014 at 08:21:03PM +0300, Antti Palosaari wrote:
> On 05/17/2014 07:05 PM, Martin Kepplinger wrote:
> >don't reinvent dev_dbg(). remove dprintk() in as102_drv.c.
> >use the common kernel coding style.
> >
> >Signed-off-by: Martin Kepplinger <martink@...teo.de>
>
> Reviewed-by: Antti Palosaari <crope@....fi>
>
> >---
> >this applies to next-20140516. any more suggestions?
> >more cleanup can be done when dprintk() is completely gone.
>
> Do you have the device? I am a bit reluctant patching that driver
> without any testing as it has happened too many times something has
> gone totally broken.
Looking through the log the only time I see breakage is build breakage
on allyesconfig.
1ec9a35 [media] staging: as102: Add missing function argument
This was a compile warning and it definitely should have been caught
before the code was submitted or merged, but it wasn't something people
would hit in real life.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists