linux-kernel - Re: [PATCH v2 RFC 1/3] MAINTAINERS: Add "R:" designated-reviewers tag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 3 Jun 2014 14:48:09 -0700
From:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:	Joe Perches <joe@...ches.com>
Cc:	linux-kernel@...r.kernel.org, mingo@...nel.org,
	laijs@...fujitsu.com, dipankar@...ibm.com,
	akpm@...ux-foundation.org, mathieu.desnoyers@...icios.com,
	josh@...htriplett.org, niv@...ibm.com, tglx@...utronix.de,
	peterz@...radead.org, rostedt@...dmis.org, dhowells@...hat.com,
	edumazet@...gle.com, dvhart@...ux.intel.com, fweisbec@...il.com,
	oleg@...hat.com, sbw@....edu
Subject: Re: [PATCH v2 RFC 1/3] MAINTAINERS: Add "R:" designated-reviewers tag

On Tue, Jun 03, 2014 at 01:16:07PM -0700, Joe Perches wrote:
> On Tue, 2014-06-03 at 13:12 -0700, Paul E. McKenney wrote:
> > On Tue, Jun 03, 2014 at 12:03:07PM -0700, Joe Perches wrote:
> > > On Tue, 2014-06-03 at 08:35 -0700, Paul E. McKenney wrote:
> > > > Paul Walmsley also noted the need for patch
> > > > submitters to know who the key reviewers are and suggested adding an
> > > > "R:" tag to the MAINTAINERS file to record this information on a
> > > > per-subsystem basis.
> > > []
> > > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > []
> > > > @@ -70,6 +70,8 @@ Descriptions of section entries:
> > > >  
> > > >  	P: Person (obsolete)
> > > >  	M: Mail patches to: FullName <address@...ain>
> > > > +	R: Designated reviewer, who should be CCed on patches,
> > > > +	   format: FullName <address@...ain>
> > > >  	L: Mailing list that is relevant to this area
> > > >  	W: Web-page with status/info
> > > >  	Q: Patchwork web based patch tracking system site
> > > 
> > > Perhaps the M: and R: roles should be more fully
> > > described here.
> > > 
> > > The R: entry description doesn't need commas.
> > > 
> > > Maybe something like:
> > > 	M: Maintainer (to:) FullName <address@...ain>
> > > 	R: Reviewer   (cc:) FullName <address@...ain>
> > 
> > This is arguably better organized, but I need to keep my focus on adding
> > the designated reviewer.  I am not in a position to undertake a rewrite
> > of the MAINTAINER file preamble at this point.
> 
> That's silly, you're adding the "R" entry.
> Add a proper description for it.

I will take another look at R: in a few days and possibly wordsmith it.

> > > You might as well send the get_maintainer update with this
> > > series too.
> > 
> > Interesting...  Who is the maintainer for get_maintainer?  ;-)
> 
> Some numbskull just signed up for that.
> 
> He suggests you keep all the patches that add
> support for this "R: reviewer" feature together.

My reluctance is due to the fact that this will change how newbies
submit patches.  But if we get a few Acked-by or Reviewed-by responses
from high-level maintainers (Linus, Greg, Ingo, Thomas, Peter, Ted,
Dave, Ben, ...), I will of course be happy to queue it.

							Thanx, Paul

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/