linux-kernel - Re: [PATCH 1/1] perf/amd: NULL return of kzalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAABZP2x9ag6eAsL0si9j_TQNjM7jjTDf2UgYZ6ZtqBr2t_zQKQ@mail.gmail.com>
Date:	Tue, 10 Jun 2014 16:45:46 +0800
From:	Zhouyi Zhou <zhouzhouyi@...il.com>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	paulus@...ba.org, mingo@...hat.com, acme@...nel.org,
	tglx@...utronix.de, hpa@...or.com, x86@...nel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Zhouyi Zhou <yizhouzhou@....ac.cn>
Subject: Re: [PATCH 1/1] perf/amd: NULL return of kzalloc_node should be handled

Thanks Peter for reviewing, and sorry for not think it thoroughly
before submitting.
Is that ok that when amd_uncore_cpu_up_prepare is called from
amd_uncore_cpu_notifier
I return notifier_from_errno(-ENOMEM), and  when
amd_uncore_cpu_up_prepare is called from
amd_uncore_init I immediately return  -ENODEV?

On Tue, Jun 10, 2014 at 4:22 PM, Peter Zijlstra <peterz@...radead.org> wrote:
> On Tue, Jun 10, 2014 at 03:37:38PM +0800, Zhouyi Zhou wrote:
>
> Less typing more thinking, this is wrong. You should fail when the
> allocation fails.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/