linux-kernel - Re: [PATCH 6/9] perf bench: futex: Replace --silent option with global --format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1403197317.29394.14.camel@buesod1.americas.hpqcorp.net>
Date:	Thu, 19 Jun 2014 10:01:57 -0700
From:	Davidlohr Bueso <davidlohr@...com>
To:	Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:	jolsa@...nel.org, mitake@....info.waseda.ac.jp, aswin@...com,
	Ingo Molnar <mingo@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 6/9] perf bench: futex: Replace --silent option with
 global --format

On Thu, 2014-06-19 at 13:38 -0300, Arnaldo Carvalho de Melo wrote:
> Em Mon, Jun 16, 2014 at 11:14:24AM -0700, Davidlohr Bueso escreveu:
> > Using the already existing '--format simple' option in perf-bench
> > is/should be equivalent to disabling any verbose output. Replace
> > it and free up the -s option specific to the futex benchmark.
> 
> Isn't this much longer?

It is, and to be honest I detest the whole --format option. But its
already there and I really want to make use of global parameters in
order to recycle options that are benchmark-specific. What I'd really
like is to replace it with --silent and just have perf spit out the raw
data (for scripting). But that would be too disruptive to users, imho.
Does it matter? I dunno.

> I haven't seen any patch in this series wanting to use -s.
> 
> Ingo, are you Ok with this?
> 
> I.e. I'm just trying to be careful when changing existing cmd line args,
> perhaps someone is used to this, who knows, and at least for me,
> --silent is way, way more clear than '--format simple', that says
> nothing to me.

If we can get away with it then lets.

Thanks,
Davidlohr

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/