linux-kernel - Re: [PATCH 2/9] perf bench: sched-messaging: Redo runtime output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140619193026.GC31524@kernel.org>
Date:	Thu, 19 Jun 2014 16:30:26 -0300
From:	Arnaldo Carvalho de Melo <acme@...nel.org>
To:	Davidlohr Bueso <davidlohr@...com>
Cc:	jolsa@...nel.org, mitake@....info.waseda.ac.jp, aswin@...com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/9] perf bench: sched-messaging: Redo runtime output

Em Mon, Jun 16, 2014 at 11:14:20AM -0700, Davidlohr Bueso escreveu:
> Instead of printing sec and usec individually, simplify
> into a 'runtime' variable to later use accordingly. This
> is particularly helpful when later adding multiple runs
> and collecting statistics.
> 
> Signed-off-by: Davidlohr Bueso <davidlohr@...com>
> ---
>  tools/perf/bench/sched-messaging.c | 13 +++++--------
>  1 file changed, 5 insertions(+), 8 deletions(-)
> 
> diff --git a/tools/perf/bench/sched-messaging.c b/tools/perf/bench/sched-messaging.c
> index cc1190a..df0828a 100644
> --- a/tools/perf/bench/sched-messaging.c
> +++ b/tools/perf/bench/sched-messaging.c
> @@ -269,9 +269,9 @@ static const char * const bench_sched_message_usage[] = {
>  int bench_sched_messaging(int argc, const char **argv,
>  		    const char *prefix __maybe_unused)
>  {
> -	unsigned int i, total_children;
> +	unsigned int i, total_children, num_fds = 20;
>  	struct timeval start, stop, diff;
> -	unsigned int num_fds = 20;
> +	unsigned long runtime;
>  	int readyfds[2], wakefds[2];
>  	char dummy;
>  	pthread_t *pth_tab;
> @@ -307,8 +307,8 @@ int bench_sched_messaging(int argc, const char **argv,
>  		reap_worker(pth_tab[i]);
>  
>  	gettimeofday(&stop, NULL);
> -
>  	timersub(&stop, &start, &diff);
> +	runtime = (diff.tv_sec * 1e3) + (diff.tv_usec/1e3);

So if you want to really change this into something more compact, why
not declare runtime as float and do the div here, so that you don't have
to do it everytime you need to format it?

But perhaps because in the kernel we avoid doing floating point I found
this code unusual, was expecting things like USEC_PER_MSEC, and no
floating pointing operations being used, i.e. as before :-\

Anyway, I took most of the patches in this series, will push what I have
after some more testing.

- Arnaldo

>  
>  	switch (bench_format) {
>  	case BENCH_FORMAT_DEFAULT:
> @@ -317,13 +317,10 @@ int bench_sched_messaging(int argc, const char **argv,
>  		printf("# %d groups == %d %s run\n\n",
>  		       num_groups, num_groups * 2 * num_fds,
>  		       thread_mode ? "threads" : "processes");
> -		printf(" %14s: %lu.%03lu [sec]\n", "Total time",
> -		       diff.tv_sec,
> -		       (unsigned long) (diff.tv_usec/1000));
> +		printf(" %14s: %.3f [sec]\n", "Total time", runtime/1e3);
>  		break;
>  	case BENCH_FORMAT_SIMPLE:
> -		printf("%lu.%03lu\n", diff.tv_sec,
> -		       (unsigned long) (diff.tv_usec/1000));
> +		printf("%.3f\n", runtime/1e3);
>  		break;
>  	default:
>  		/* reaching here is something disaster */
> -- 
> 1.8.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/