linux-kernel - Re: [PATCHv3 2/2] Add force_epp module option for parport

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140710170813.GA23544@kroah.com>
Date:	Thu, 10 Jul 2014 10:08:13 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>
Cc:	"Matwey V. Kornilov" <matwey@....msu.ru>,
	linux-kernel@...r.kernel.org, linux-parport@...ts.infradead.org,
	hsommer@....org, matwey.kornilov@...il.com
Subject: Re: [PATCHv3 2/2] Add force_epp module option for parport_pc.

On Thu, Jul 10, 2014 at 04:52:25PM +0100, One Thousand Gnomes wrote:
> > module parameters are horrid, how is someone supposed to know to use
> > this?  Why can't we "fix" the detection logic?  You just now broke
> > systems that were working by forcing them to now set a module option
> > where previously they didn't, so I can't take these patches as-is,
> > sorry.
> 
> Can we not just add "if the CPU is PPro or higher than all is fine" ? to
> the test ?

That sounds reasonable to me.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/