linux-kernel - Re: [PATCH 1/1] rcu: Fix build failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140719004747.GA4782@linux.vnet.ibm.com>
Date:	Fri, 18 Jul 2014 17:47:47 -0700
From:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:	Pranith Kumar <bobby.prani@...il.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Josh Triplett <josh@...htriplett.org>
Subject: Re: [PATCH 1/1] rcu: Fix build failure

On Fri, Jul 18, 2014 at 01:30:52PM -0400, Pranith Kumar wrote:
> Hi Paul,
> 
> While running the kvm rcutorture test scripts, I encountered a build failure caused by
> 
> Commit 918179699e4a ("rcu: Don't keep timekeeping CPU tick running for non-nohz_full= CPUs")
> 
> This commit fixes the failure. This is on top of paul/rcu/dev.
> 
> Signed-off-by: Pranith Kumar <bobby.prani@...il.com>
> ---
>  kernel/rcu/tree_plugin.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/rcu/tree_plugin.h b/kernel/rcu/tree_plugin.h
> index 5591276..eaa32e4 100644
> --- a/kernel/rcu/tree_plugin.h
> +++ b/kernel/rcu/tree_plugin.h
> @@ -2795,7 +2795,7 @@ static void rcu_sysidle_exit(struct rcu_dynticks *rdtp, int irq)
>  	 * CPU to keep a tick on our behalf.  We assume that the timekeeping
>  	 * CPU is also a nohz_full= CPU.
>  	 */
> -	if (!tick_nohz_full_cpu(cpu))
> +	if (!tick_nohz_full_cpu(smp_processor_id()))

Good catch, but please see 770d957e (rcu: Don't keep timekeeping CPU
tick running for non-nohz_full= CPUs).  ;-)

								Thanx, Paul

>  		return;
>  
>  	/* Update system-idle state: We are clearly no longer fully idle! */
> -- 
> 1.9.1
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/