linux-kernel - Re: [PATCH v2 5/6] KVM: trace kvm_ple

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140821134916.GF20453@potion.brq.redhat.com>
Date:	Thu, 21 Aug 2014 15:49:17 +0200
From:	Radim Krčmář <rkrcmar@...hat.com>
To:	Paolo Bonzini <pbonzini@...hat.com>
Cc:	kvm@...r.kernel.org, linux-kernel@...r.kernel.org,
	Gleb Natapov <gleb@...nel.org>,
	Raghavendra KT <raghavendra.kt@...ux.vnet.ibm.com>,
	Vinod Chegu <chegu_vinod@...com>,
	Hui-Zhi <hui-zhi.zhao@...com>,
	Christian Borntraeger <borntraeger@...ibm.com>
Subject: Re: [PATCH v2 5/6] KVM: trace kvm_ple_window

2014-08-21 15:22+0200, Paolo Bonzini:
> Il 21/08/2014 13:56, Radim Krčmář ha scritto:
> > 2014-08-21 10:29+0200, Paolo Bonzini:
> >> Il 20/08/2014 22:53, Radim Krčmář ha scritto:
> >>> +	TP_PROTO(int grow, unsigned int vcpu_id, int new, int old),
> >>
> >> s/int grow/bool grow/ (and similarly in TP_STRUCT__entry).
> > 
> > Ok.
> > (We are using 'int' for this in other tracepoints, so I guessed there is
> >  some hate agains bool.)
> 
> Yeah, there are many ints, but there are also some bools. :)
> 
> Of course "bool" is only a no-brainer if there is a clear direction to
> use (e.g. "bool has_error"), and indeed this case is less obvious.  But
> there are some like this one (e.g. bool gpa_match).
> 
> Keep the int if you prefer it that way.

I actually like bool much better, but first few were only int and then I
stopped looking ...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/