linux-kernel - Re: [PATCH] sched: Use RCU read lock on all calls to dl_bw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141002092428.GA2849@worktop.programming.kicks-ass.net>
Date:	Thu, 2 Oct 2014 11:24:28 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Kirill Tkhai <ktkhai@...allels.com>
Cc:	Sasha Levin <sasha.levin@...cle.com>, mingo@...nel.org,
	torvalds@...ux-foundation.org, paulmck@...ux.vnet.ibm.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sched: Use RCU read lock on all calls to dl_bw_of()

On Tue, Sep 30, 2014 at 12:23:37PM +0400, Kirill Tkhai wrote:
> [PATCH]sched: Use dl_bw_of() under preempt_disable()
> 
> rq->rd is freed using call_rcu_sched(), so rcu_read_lock() to access it
> is not enough. We should use either rcu_read_lock_sched() or preempt_disable().
> 
> We choose preempt_disable()/preempt_enable() like in other places
> where rq->rd is used.

I changed it to rcu_read_lock_sched(), but no biggie, thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/