linux-kernel - Re: [PATCH 2/5] regulator: rt5033: Add RT5033 Regulator device driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141107102752.GC8509@sirena.org.uk>
Date:	Fri, 7 Nov 2014 10:27:52 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Beomho Seo <beomho.seo@...sung.com>
Cc:	linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
	devicetree@...r.kernel.org, sameo@...ux.intel.com,
	lee.jones@...aro.org, lgirdwood@...il.com, sre@...nel.org,
	dbaryshkov@...il.com, dwmw2@...radead.org, robh+dt@...nel.org,
	pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
	kyungmin.park@...sung.com, cw00.choi@...sung.com,
	jonghwa3.lee@...sung.com, geunsik.lim@...sung.com,
	inki.dae@...sung.com, sw0312.kim@...sung.com
Subject: Re: [PATCH 2/5] regulator: rt5033: Add RT5033 Regulator device driver

On Fri, Nov 07, 2014 at 11:52:04AM +0900, Beomho Seo wrote:

> +static int rt5033_regulator_dt_parse_data(struct device *dev)
> +{
> +	int ret;
> +	struct device_node *np;
> +
> +	np = of_get_child_by_name(dev->parent->of_node, "regulators");
> +	if  (!np) {
> +		dev_err(dev, "Failed to get child node for regulators\n");
> +		return -EINVAL;
> +	}
> +
> +	ret = of_regulator_match(dev, np, rt5033_regulator_matches,
> +					ARRAY_SIZE(rt5033_regulator_matches));
> +	if (ret < 0)
> +		return ret;

Please convert this to use regulators_node in the descriptor to match
the regulators, then you don't need any specific code.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)