linux-kernel - Re: [PATCH 5/5] Documentation: Add documentation for rt5033 multifunction device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141107103440.GD8509@sirena.org.uk>
Date:	Fri, 7 Nov 2014 10:34:40 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Beomho Seo <beomho.seo@...sung.com>
Cc:	linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
	devicetree@...r.kernel.org, sameo@...ux.intel.com,
	lee.jones@...aro.org, lgirdwood@...il.com, sre@...nel.org,
	dbaryshkov@...il.com, dwmw2@...radead.org, robh+dt@...nel.org,
	pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
	kyungmin.park@...sung.com, cw00.choi@...sung.com,
	jonghwa3.lee@...sung.com, geunsik.lim@...sung.com,
	inki.dae@...sung.com, sw0312.kim@...sung.com
Subject: Re: [PATCH 5/5] Documentation: Add documentation for rt5033
 multifunction device

On Fri, Nov 07, 2014 at 11:52:07AM +0900, Beomho Seo wrote:

> +Required properties:
> +- compatible = Must be "richtek,rt5033-regulator"
> +
> +	regulators {
> +		compatible = "richtek,rt5033-regulator";

There should be no need for this extra compatible, it's not adding
anything we didn't know from the fact that it's part of the MFD.

> +		regulator-name {
> +			regulator-name = LDO/BUCK
> +			standard regulator constraints...
> +		};

Better to just say something like "regulator subnodes called X, Y and Z"
described using the standard regulator binding in...

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)