linux-kernel - Re: [PATCH v1] libata: export ata_get_cmd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1420479885.12456.21.camel@linux.intel.com>
Date:	Mon, 05 Jan 2015 19:44:45 +0200
From:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:	Tejun Heo <tj@...nel.org>
Cc:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
	linux-kernel@...r.kernel.org, linux-ide@...r.kernel.org
Subject: Re: [PATCH v1] libata: export ata_get_cmd_descript()

On Mon, 2015-01-05 at 11:21 -0500, Tejun Heo wrote:
> On Fri, Dec 12, 2014 at 07:35:47PM +0200, Andy Shevchenko wrote:
> > On Fri, 2014-12-12 at 20:25 +0300, Sergei Shtylyov wrote:
> > > Hello.
> > > 
> > > On 12/12/2014 06:16 PM, Andy Shevchenko wrote:
> > > 
> > > > The driver sata_dwc_460ex is using this symbol. To build it as a module we have
> > > > to have the symbol exported. This patch adds EXPORT_SYMBOL() macro for that.
> > > 
> > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> > > > ---
> > > >   drivers/ata/libata-eh.c | 1 +
> > > >   1 file changed, 1 insertion(+)
> > > 
> > > > diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
> > > > index 3dbec89..74fef87 100644
> > > > --- a/drivers/ata/libata-eh.c
> > > > +++ b/drivers/ata/libata-eh.c
> > > > @@ -2389,6 +2389,7 @@ const char *ata_get_cmd_descript(u8 command)
> > > >
> > > >   	return NULL;
> > > >   }
> > > > +EXPORT_SYMBOL(ata_get_cmd_descript);
> > > 
> > >     Why not EXPORT_SYMBOL_GPL()?
> > 
> > Some of the symbols are exported in that way. I think better to wait the
> > maintainer to tell which is preferred there.
> 
> I don't really care.  As the sole user is an in-kernel module, I'm
> gonna append _GPL for now.
> 

I'm okay with GPL. Thanks!


-- 
Andy Shevchenko <andriy.shevchenko@...el.com>
Intel Finland Oy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/