linux-kernel - Re: [PATCH v2] usb: dwc2: call dwc2_is_controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1501141636590.1464-100000@iolanthe.rowland.org>
Date:	Wed, 14 Jan 2015 16:41:23 -0500 (EST)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Felipe Balbi <balbi@...com>
cc:	Robert Baldyga <r.baldyga@...sung.com>, <paulz@...opsys.com>,
	<gregkh@...uxfoundation.org>, <linux-usb@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <dinguyen@...nsource.altera.com>,
	<yousaf.kaukab@...el.com>, <m.szyprowski@...sung.com>
Subject: Re: [PATCH v2] usb: dwc2: call dwc2_is_controller_alive() under
 spinlock

On Wed, 14 Jan 2015, Felipe Balbi wrote:

> > > This is really, really odd. Register accesses are atomic, so the lock
> > > isn't really doing anything. Besides, you're calling
> > > dwc2_is_controller_alive() from within the IRQ handler, so IRQs are
> > > already disabled.
> > 
> > Spinlocks sometimes do more than you think.  For instance, here the 
> > lock prevents the register access from happening while some other CPU 
> > is holding the lock.  If a silicon quirk causes the register access to 
> > interfere with other activities, this could be important.
> 
> readl() (which is used by dwc2_is_controller_alive()) adds a memory
> barrier to the register accesses, that should force all register
> accesses the be correctly ordered.

Memory barriers will order accesses that are all made on the same CPU
with respect to each other.  They do not order these accesses against
accesses made from another CPU -- that's why we have spinlocks.  :-)

>  I fail to see how a silicon quirk
> could cause this and if, indeed, it does, I'd be more comfortable with a
> proper STARS tickect number from synopsys :-s

Maybe accessing this register somehow resets something else.  I don't 
know.  It seems unlikely, but at least it explains how adding a 
spinlock could fix the problem.

> Then again, I don't even have a device with this controller and it seems
> to only be a problem with Robert's setup, so maybe it's a silicon bug
> caused by whoever integrated dwc2 in his silicon.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/