linux-kernel - Re: [PATCH] include:linux:Optimizations to __skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89i+anRV98Y_EQGvMiPvc-JUu9KxmP2SY7kYXvjVw3Dj-KQ@mail.gmail.com>
Date:	Thu, 22 Jan 2015 10:24:45 -0800
From:	Eric Dumazet <edumazet@...gle.com>
To:	Tom Herbert <therbert@...gle.com>
Cc:	Mohammad Jamal <md.jamalmohiuddin@...il.com>,
	David Miller <davem@...emloft.net>, viro@...iv.linux.org.uk,
	Alexander Duyck <alexander.h.duyck@...hat.com>,
	Willem de Bruijn <willemb@...gle.com>,
	Hannes Frederic Sowa <hannes@...essinduktion.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] include:linux:Optimizations to __skb_push

On Thu, Jan 22, 2015 at 10:21 AM, Tom Herbert <therbert@...gle.com> wrote:

> Hmm, this seems less readable to me. What is the effect of this patch?
> Does the compiler even produce different assembly?

No change at all in generated assembly, this looks not worth it.

BTW, most __skb_push() callers ignore return value.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/