linux-kernel - Re: [PATCH 4/4] sound: jz4740: Enable codec clock during dai

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 26 Jan 2015 11:40:00 +0100
From:	Lars-Peter Clausen <lars@...afoo.de>
To:	Zubair Lutfullah Kakakhel <Zubair.Kakakhel@...tec.com>,
	tiwai@...e.de, perex@...ex.cz
CC:	broonie@...nel.org, lgirdwood@...il.com,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
	alsa-devel@...a-project.org
Subject: Re: [PATCH 4/4] sound: jz4740: Enable codec clock during dai_probe

On 01/26/2015 11:18 AM, Zubair Lutfullah Kakakhel wrote:
> As we are moving away from platform to DT, we cant rely on the board
> file to do this now. So enable it here.

I don't understand this changelog. The board file never did this. The driver 
enables the clock in the startup() callback.

>
> Signed-off-by: Zubair Lutfullah Kakakhel <Zubair.Kakakhel@...tec.com>
> ---
>   sound/soc/jz4740/jz4740-i2s.c | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/sound/soc/jz4740/jz4740-i2s.c b/sound/soc/jz4740/jz4740-i2s.c
> index 3c309fc..a7e4a7b 100644
> --- a/sound/soc/jz4740/jz4740-i2s.c
> +++ b/sound/soc/jz4740/jz4740-i2s.c
> @@ -376,6 +376,10 @@ static int jz4740_i2s_dai_probe(struct snd_soc_dai *dai)
>   		JZ_AIC_CONF_I2S |
>   		JZ_AIC_CONF_INTERNAL_CODEC;
>
> +	/* enable codec sysclk */
> +	clk_set_rate(i2s->clk_i2s, 12000000);
> +	clk_prepare_enable(i2s->clk_i2s);
> +
>   	jz4740_i2s_write(i2s, JZ_REG_AIC_CONF, JZ_AIC_CONF_RESET);
>   	jz4740_i2s_write(i2s, JZ_REG_AIC_CONF, conf);
>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/