lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 22 Mar 2015 21:59:57 +0100 From: Andrew Lunn <andrew@...n.ch> To: Guenter Roeck <linux@...ck-us.net> Cc: netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, Florian Fainelli <f.fainelli@...il.com>, linux-kernel@...r.kernel.org Subject: Re: [PATCH 08/18] net: dsa: mv88e6xxx: Add Hardware bridging support On Sun, Mar 22, 2015 at 01:45:49PM -0700, Guenter Roeck wrote: > On 03/22/2015 01:06 PM, Andrew Lunn wrote: > >Hi Guenter > > > >>+static int _mv88e6xxx_atu_cmd(struct dsa_switch *ds, int fid, u16 cmd) > >>+{ > >>+ int ret; > >>+ > >>+ ret = _mv88e6xxx_reg_write(ds, REG_GLOBAL, 0x01, fid); > >>+ if (ret < 0) > >>+ return ret; > > > >Please could you check this. I think register 0x01 here is wrong. I > >think you want 0x0b, the ATU Operations register? > > > The ATU operation is initiated below (and does write to register 0x0b). > Register 0x01 is FID[11..0] for ATU, which is what we want to write here. http://lxr.free-electrons.com/source/drivers/net/dsa/mv88e6xxx.c#L156 156 int mv88e6xxx_set_addr_direct(struct dsa_switch *ds, u8 *addr) 157 { 158 REG_WRITE(REG_GLOBAL, 0x01, (addr[0] << 8) | addr[1]); 159 REG_WRITE(REG_GLOBAL, 0x02, (addr[2] << 8) | addr[3]); 160 REG_WRITE(REG_GLOBAL, 0x03, (addr[4] << 8) | addr[5]); 161 162 return 0; 163 } So maybe the meaning of these registers has changed between different versions of the chips? Only 6131 uses mv88e6xxx_set_addr_direct, all the others use indirect method. So maybe the 6131 is going to need something different here in _mv88e6xxx_atu_cmd()? Andrew -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists